Hi Patrick
On 6/1/22 18:33, Patrick Delaunay wrote:
> Depending on backup register value, U-Boot SPL maintains the debug unit
> powered-on for debugging purpose; only BUCK1 is required for powering
> the debug unit, so revert the setting for all the other power lanes,
> except BUCK3 that has to be always on.
>
> To be functional this patch requires a modification in the debugger
> ,openocd for example, to update the STM32MP15 backup register when it is
> required to debug SPL after reset. After deeper analysis this behavior
> will be never supported in tools so the associated code, will be never
> used and the associated code can be removed.
>
> Signed-off-by: Patrick Delaunay <patrick.delau...@foss.st.com>
> ---
>
> arch/arm/mach-stm32mp/include/mach/stm32.h | 1 -
> board/st/common/stpmic1.c | 14 --------------
> include/power/stpmic1.h | 3 ---
> 3 files changed, 18 deletions(-)
>
> diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h
> b/arch/arm/mach-stm32mp/include/mach/stm32.h
> index 47e88fc3dc..13cb7db9f0 100644
> --- a/arch/arm/mach-stm32mp/include/mach/stm32.h
> +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h
> @@ -117,7 +117,6 @@ enum boot_device {
> #define TAMP_BOOT_DEVICE_MASK GENMASK(7, 4)
> #define TAMP_BOOT_INSTANCE_MASK GENMASK(3, 0)
> #define TAMP_BOOT_FORCED_MASK GENMASK(7, 0)
> -#define TAMP_BOOT_DEBUG_ON BIT(16)
>
> enum forced_boot_mode {
> BOOT_NORMAL = 0x00,
> diff --git a/board/st/common/stpmic1.c b/board/st/common/stpmic1.c
> index 5fb1be2fd3..d52dce4f65 100644
> --- a/board/st/common/stpmic1.c
> +++ b/board/st/common/stpmic1.c
> @@ -202,18 +202,4 @@ void stpmic1_init(u32 voltage_mv)
> STPMIC1_BUCKS_MRST_CR,
> STPMIC1_MRST_BUCK(STPMIC1_BUCK3),
> STPMIC1_MRST_BUCK(STPMIC1_BUCK3));
> -
> - /* Check if debug is enabled to program PMIC according to the bit */
> - if (readl(TAMP_BOOT_CONTEXT) & TAMP_BOOT_DEBUG_ON) {
> - log_info("Keep debug unit ON\n");
> -
> - pmic_clrsetbits(dev, STPMIC1_BUCKS_MRST_CR,
> - STPMIC1_MRST_BUCK_DEBUG,
> - STPMIC1_MRST_BUCK_DEBUG);
> -
> - if (STPMIC1_MRST_LDO_DEBUG)
> - pmic_clrsetbits(dev, STPMIC1_LDOS_MRST_CR,
> - STPMIC1_MRST_LDO_DEBUG,
> - STPMIC1_MRST_LDO_DEBUG);
> - }
> }
> diff --git a/include/power/stpmic1.h b/include/power/stpmic1.h
> index d3567df326..201b1df762 100644
> --- a/include/power/stpmic1.h
> +++ b/include/power/stpmic1.h
> @@ -23,12 +23,9 @@
>
> /* BUCKS_MRST_CR */
> #define STPMIC1_MRST_BUCK(buck) BIT(buck)
> -#define STPMIC1_MRST_BUCK_DEBUG
> (STPMIC1_MRST_BUCK(STPMIC1_BUCK1) | \
> - STPMIC1_MRST_BUCK(STPMIC1_BUCK3))
>
> /* LDOS_MRST_CR */
> #define STPMIC1_MRST_LDO(ldo) BIT(ldo)
> -#define STPMIC1_MRST_LDO_DEBUG 0
>
> /* BUCKx_MAIN_CR (x=1...4) */
> #define STPMIC1_BUCK_ENA BIT(0)
Reviewed-by: Patrice Chotard <patrice.chot...@foss.st.com>
Thanks
Patrice
