Hi,

On 6/9/22 14:30, Sughosh Ganu wrote:
From: Masami Hiramatsu <masami.hirama...@linaro.org>

Add a devicetree-binding YAML file for the FWU metadata on MTD
devices without GPT.

Signed-off-by: Masami Hiramatsu <masami.hirama...@linaro.org>
Signed-off-by: Sughosh Ganu <sughosh.g...@linaro.org>
---
  .../firmware/uboot,fwu-mdata-mtd.yaml         | 38 +++++++++++++++++++
  1 file changed, 38 insertions(+)
  create mode 100644 doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml

diff --git a/doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml 
b/doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml
new file mode 100644
index 0000000000..4f5404f999
--- /dev/null
+++ b/doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/firmware/u-boot,fwu-mdata-sf.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: FWU metadata on MTD device without GPT
+
+maintainers:
+ - Masami Hiramatsu <masami.hirama...@linaro.org>
+
+properties:
+  compatible:
+    items:
+      - const: u-boot,fwu-mdata-mtd
+
+  fwu-mdata-store:
+    maxItems: 1
+    description: Phandle of the MTD device which contains the FWU medatata.
+
+  mdata-offsets:
+    minItems: 2
+    description: Offsets of the primary and secondary FWU metadata in the NOR 
flash.
+
+required:
+  - compatible
+  - fwu-mdata-store
+  - mdata-offsets
+
+additionalProperties: false
+
+examples:
+  - |
+    fwu-mdata {
+        compatible = "u-boot,fwu-mdata-mtd";
+        fwu-mdata-store = <&spi-flash>;
+        mdata-offsets = <0x500000 0x530000>;
+    };

Do you need to have offset her => normally it is already managed by mtd partition


    spi-flash@0 {
        #address-cells = <1>;
        #size-cells = <1>;
        compatible = "spi-flash", "jedec,spi-nor";
....
        metadata1: partition@metadata1 {
            reg = <0x500000 0x30000>;
            label = "metadata1";
        };
        metadata2: partition@metadata2 {
            reg = <0x530000 0x30000>;
            label = "metadata2";
        };
....
    };


So the needed offset information can be found with 2 handles

to the MTD partitions in the device tree !

+    fwu-mdata {
+        compatible = "u-boot,fwu-mdata-mtd";
+        fwu-mdata-store = <&metadata1>, <&metadata2>;
+    };


This proposal can simplify the binding

+  fwu-mdata-store:
+    maxItems: 2
+    description: Phandle of the two MTD partitions which contains the FWU 
medatata.

+required:
+  - compatible
+  - fwu-mdata-store

Patrick

Reply via email to