Hi Ramon, Thanks for your review.
On Mon, 11 Jul 2022 at 20:08, Ramon Fried <rfried....@gmail.com> wrote: > > On Fri, Jul 8, 2022 at 4:14 PM Sumit Garg <sumit.g...@linaro.org> wrote: > > > > Currently its a dummy clock driver as clocks for UART and eMMC have been > > already enabled by ABL. Along with this import "qcom,gcc-qcs404.h" header > > from Linux mainline to support DT bindings. > I think it's better to initialize the clocks also here, this will > allow the u-boot to be used > instead of ABL. Actually, ABL is just an EFI application that is dependent on the EFI API exposed from XBL which is essentially an edk2 based implementation. The XBL source code is proprietary and its a signed locked down bootloader which isn't replaceable. Although it may be possible to run u-boot as an EFI application in the future then it could be a replacement for ABL but still for driver backends it will rely on XBL exposed EFI API. > If it's a simple clock configuration, it's not a > problem to re-init it after ABL already did. Yeah it's simple enough configuration to be done but earlier I was looking for a use-case. So nevertheless it's better for clarity at least that we aren't relying on a blackbox implementation underneath. I will add it in the next version. -Sumit
