El Fri, Jul 15, 2022 at 05:14:26PM +0200, Quentin Schulz deia: > From: Quentin Schulz <quentin.sch...@theobroma-systems.com> > > An earlier commit makes the common SPL code call > regulators_enable_boot_on and regulators_enable_boot_off before > iterating over possible boot media for U-Boot proper. There is therefore > no need to do this in the rk3399-specific code, so let's remove it. > > Cc: Quentin Schulz <foss+ub...@0leil.net> > Signed-off-by: Quentin Schulz <quentin.sch...@theobroma-systems.com> > --- >
Tested on a Rock-Pi-4B and didn't see any regression. Tested-by: Xavier Drudis Ferran <xdru...@tinet.cat> > - This patch depends on > https://lore.kernel.org/u-boot/20220715150949.952853-1-foss+ub...@0leil.net/ > and > https://lore.kernel.org/u-boot/20220715150949.952853-2-foss+ub...@0leil.net/ > > arch/arm/mach-rockchip/rk3399/rk3399.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c > b/arch/arm/mach-rockchip/rk3399/rk3399.c > index db8a6cb83a..691d69dc59 100644 > --- a/arch/arm/mach-rockchip/rk3399/rk3399.c > +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c > @@ -277,15 +277,5 @@ void spl_board_init(void) > if (cru->glb_rst_st != 0) > rk3399_force_power_on_reset(); > } > - > - if (IS_ENABLED(CONFIG_SPL_DM_REGULATOR)) { > - /* > - * Turning the eMMC and SPI back on (if disabled via the Qseven > - * BIOS_ENABLE) signal is done through a always-on regulator). > - */ > - if (regulators_enable_boot_on(false)) > - debug("%s: Cannot enable boot on regulator\n", > - __func__); > - } > } > #endif > -- > 2.36.1 >
