On 25.07.22 14:08, Pali Rohár wrote:
grp->pins is just filled and never used. Remove it.
Signed-off-by: Pali Rohár <p...@kernel.org>
Reviewed-by: Stefan Roese <s...@denx.de>
Thanks,
Stefan
---
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index e76ef153e604..610535fa2392 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -65,7 +65,6 @@ DECLARE_GLOBAL_DATA_PTR;
* belonging to the group
* @npins: Number of pins included in the second optional range
* @funcs: A list of pinmux functions that can be selected for this group.
- * @pins: List of the pins included in the group
*/
struct armada_37xx_pin_group {
const char *name;
@@ -76,7 +75,6 @@ struct armada_37xx_pin_group {
unsigned int extra_pin;
unsigned int extra_npins;
const char *funcs[NB_FUNCS];
- unsigned int *pins;
};
struct armada_37xx_pin_data {
@@ -354,19 +352,7 @@ static int armada_37xx_fill_group(struct
armada_37xx_pinctrl *info)
for (n = 0; n < info->ngroups; n++) {
struct armada_37xx_pin_group *grp = &info->groups[n];
- int i, j, f;
-
- grp->pins = devm_kzalloc(info->dev,
- (grp->npins + grp->extra_npins) *
- sizeof(*grp->pins), GFP_KERNEL);
- if (!grp->pins)
- return -ENOMEM;
-
- for (i = 0; i < grp->npins; i++)
- grp->pins[i] = grp->start_pin + i;
-
- for (j = 0; j < grp->extra_npins; j++)
- grp->pins[i+j] = grp->extra_pin + j;
+ int f;
for (f = 0; (f < NB_FUNCS) && grp->funcs[f]; f++) {
int ret;
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de
