On 29.07.22 09:38, Pali Rohár wrote:
On Thursday 28 July 2022 14:42:35 Tony Dinh wrote:
Hi Pali,

I noticed that PINCTRL_FULL is default to Y already in Kconfig. Is it
normal practice to include it in the defconfig anyway?

./drivers/pinctrl/Kconfig

config PINCTRL_FULL
         bool "Support full pin controllers"
         depends on PINCTRL && OF_CONTROL
         default y

Ou, I probably forgot to run make saveconfig. In this case it is not
needed and would be automatically removed after running move config
(which Tom runs periodically for all boards).

Stefan, should I resend this patch? Or do let it as is?

No need. I'll handle this by running savedefconfig and squashing it.

Thanks,
Stefan

All the best,
Tony

On Wed, Jul 27, 2022 at 11:29 PM Stefan Roese <s...@denx.de> wrote:

On 25.07.22 13:56, Pali Rohár wrote:
Signed-off-by: Pali Rohár <p...@kernel.org>

Reviewed-by: Stefan Roese <s...@denx.de>

Thanks,
Stefan

---
   configs/turris_omnia_defconfig | 4 +++-
   1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index e2a0449b487b..9b38ba93f767 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -72,7 +72,6 @@ CONFIG_NETCONSOLE=y
   CONFIG_SPL_OF_TRANSLATE=y
   CONFIG_AHCI_PCI=y
   CONFIG_AHCI_MVEBU=y
-# CONFIG_MVEBU_GPIO is not set
   CONFIG_DM_PCA953X=y
   CONFIG_MMC_SDHCI=y
   CONFIG_MMC_SDHCI_MV=y
@@ -93,6 +92,9 @@ CONFIG_PCI=y
   CONFIG_PCI_MVEBU=y
   CONFIG_DM_RTC=y
   CONFIG_RTC_ARMADA38X=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_FULL=y
+CONFIG_PINCTRL_ARMADA_38X=y
   CONFIG_SCSI=y
   CONFIG_SPL_DEBUG_UART_BASE=0xd0012000
   CONFIG_DEBUG_UART_SHIFT=2

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Reply via email to