On Tue, 2022-08-09 at 11:10 +0200, Daniel Golle wrote: > Hi Weijie, > > On Thu, Aug 04, 2022 at 11:35:03AM +0800, Weijie Gao wrote: > > This patch adds general board files based on MT7986 SoCs. > > > > The SD/eMMC controller on MT7986A and MT7986B have different pin > > configurations so that four different reference board configs has > > to be > > added. > > > > Signed-off-by: Weijie Gao <weijie....@mediatek.com> > > --- > > [...] > > diff --git a/include/configs/mt7986.h b/include/configs/mt7986.h > > new file mode 100644 > > index 0000000000..b28fc0f613 > > --- /dev/null > > +++ b/include/configs/mt7986.h > > @@ -0,0 +1,26 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Configuration for MediaTek MT7986 SoC > > + * > > + * Copyright (C) 2022 MediaTek Inc. > > + * Author: Sam Shih <sam.s...@mediatek.com> > > + */ > > + > > +#ifndef __MT7986_H > > +#define __MT7986_H > > + > > +#include <linux/sizes.h> > > + > > In the SDK sources I found also > #define CONFIG_SYS_BOOTM_LEN SZ_128M > here which is actually needed to boot any image with uncompressed > kernel larger than 8MiB. As for ARM64 this size is easily exceeded > and > we got plenty of RAM, I suggest to also include a more generous > CONFIG_SYS_BOOTM_LEN in your submission to upstream U-Boot.
CONFIG_SYS_BOOTM_LEN is now a Kconfig symbol. It will no be defined in this header. Instead, the default value of this symbol is 0x4000000 (64M) for ARM64 which is enough for an ARM64 kernel. > > > > +#define CONFIG_SYS_NONCACHED_MEMORY SZ_1M > > +#define CONFIG_SYS_MMC_ENV_DEV 0 > > + > > +/* Uboot definition */ > > +#define CONFIG_SYS_UBOOT_BASE CONFIG_SYS_TEXT_BASE > > + > > +/* SPL -> Uboot */ > > +#define CONFIG_SYS_UBOOT_START CONFIG_SYS_TEXT_BASE > > + > > +/* DRAM */ > > +#define CONFIG_SYS_SDRAM_BASE 0x40000000 > > + > > +#endif > > -- > > 2.17.1 > >