Hi Stefan, On Tue, 16 Aug 2022 at 02:42, Stefan Herbrechtsmeier <stefan.herbrechtsmeier-...@weidmueller.com> wrote: > > From: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com> > > Add an optional length header attribute to the device tree blob entry > class based on the compressed data header from the utilities to compress > and decompress data. > > If needed the header could be enabled with the following > attribute beside the compress attribute: > prepend = "length"; > > The header was introduced as part of commit eb0f4a4cb402 ("binman: > Support replacing data in a cbfs") to allow device tree entries to be > larger than the compressed contents. Regarding the commit "this is > necessary to cope with a compressed device tree being updated in such a > way that it shrinks after the entry size is already set (an obscure > case)". This case need to be fixed without influence any compressed data > by itself. > > Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com> > > --- > > (no changes since v3)
This looks fine except that it drops test coverage (binman test -T should be 100%). Please can you check it? Regards, Simon