Hi Heinrich, On Tue, 13 Sept 2022 at 10:27, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > On 8/12/22 03:35, Simon Glass wrote: > > Use the uclass ID instead. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > (no changes since v1) > > > > cmd/blk_common.c | 2 +- > > drivers/block/blk-uclass.c | 34 +++++++++++++++---------------- > > drivers/block/blk_legacy.c | 20 +++++++++---------- > > include/blk.h | 41 ++++++++++++++++++-------------------- > > include/efi_loader.h | 2 +- > > 5 files changed, 48 insertions(+), 51 deletions(-) > >
[..] > > /* EFI system partition */ > > extern struct efi_system_partition { > > - enum if_type if_type; > > + enum uclass_id if_type; > > int devnum; > > Please, rename the field if_type to class_id in a later patch. Yes, this is done in a later patch: enum uclass_id uclass_id; > > Uclass ID and device number may refer to a different device after > commands like usb init. It would be better if we could use the partition > GUID to identify a partition in the long term. But that is beyond the > scope of this series. > > Acked-by: Heinrich Schuchardt <xypron.g...@gmx.de> > Thanks for the review. Regards, Simon