Hi Alain,

On 9/12/22 10:42, Alain Volmat wrote:
From: Jorge Ramirez-Ortiz <jo...@foundries.io>

These two device tree properties were not being applied.

Fixes: 1fd9eb68d6 ("i2c: stm32f7: move driver data of each instance in a 
privdata")
Signed-off-by: Jorge Ramirez-Ortiz <jo...@foundries.io>
Reviewed-by: Alain Volmat <alain.vol...@foss.st.com>
---
  drivers/i2c/stm32f7_i2c.c | 11 ++++++-----
  1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
index 2db7f44d44..1d2dd8e25d 100644
--- a/drivers/i2c/stm32f7_i2c.c
+++ b/drivers/i2c/stm32f7_i2c.c
@@ -914,18 +914,19 @@ static int stm32_of_to_plat(struct udevice *dev)
  {
        const struct stm32_i2c_data *data;
        struct stm32_i2c_priv *i2c_priv = dev_get_priv(dev);
-       u32 rise_time, fall_time;
        int ret;
data = (const struct stm32_i2c_data *)dev_get_driver_data(dev);
        if (!data)
                return -EINVAL;
- rise_time = dev_read_u32_default(dev, "i2c-scl-rising-time-ns",
-                                        STM32_I2C_RISE_TIME_DEFAULT);
+       i2c_priv->setup.rise_time = dev_read_u32_default(dev,
+                                                        
"i2c-scl-rising-time-ns",
+                                                        
STM32_I2C_RISE_TIME_DEFAULT);
- fall_time = dev_read_u32_default(dev, "i2c-scl-falling-time-ns",
-                                        STM32_I2C_FALL_TIME_DEFAULT);
+       i2c_priv->setup.fall_time = dev_read_u32_default(dev,
+                                                        
"i2c-scl-falling-time-ns",
+                                                        
STM32_I2C_FALL_TIME_DEFAULT);
i2c_priv->dnf_dt = dev_read_u32_default(dev, "i2c-digital-filter-width-ns", 0);
        if (!dev_read_bool(dev, "i2c-digital-filter"))



Applied to u-boot-stm/master, thanks!

I also add the missing Reviewed-by when I get the patch from patchwork

http://patchwork.ozlabs.org/project/uboot/patch/20220912084201.1826979-5-alain.vol...@foss.st.com/

+  Reviewed-by: Patrice Chotard <patrice.chot...@foss.st.com>
+  Reviewed-by: Heiko Schocher <h...@denx.de>
+  Reviewed-by: Patrick Delaunay <patrick.delau...@foss.st.com>
+  Tested-by: Patrick Delaunay <patrick.delau...@foss.st.com>

Regards
Patrick


Reply via email to