On 2022/9/16 00:25, Quentin Schulz wrote:
From: Quentin Schulz <quentin.sch...@theobroma-systems.com>

CONFIG_SERIAL_TAG is not selectable for ARM64 machines. While
get_board_serial is weakly defined if ENV_VARS_UBOOT_RUNTIME_CONFIG is
defined, it is only called when CONFIG_SUPPORT_PASSING_ATAGS is defined,
which also is not selectable for ARM64 machines. Therefore this is dead
code so let's remove it.

Cc: Quentin Schulz <foss+ub...@0leil.net>
Signed-off-by: Quentin Schulz <quentin.sch...@theobroma-systems.com>
Reviewed-by: Kever Yang <kever.y...@rock-chips.com>

Thanks,
- Kever
---
  .../theobroma-systems/puma_rk3399/puma-rk3399.c  | 16 ----------------
  1 file changed, 16 deletions(-)

diff --git a/board/theobroma-systems/puma_rk3399/puma-rk3399.c 
b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
index deeba3084a..3237a6aa2e 100644
--- a/board/theobroma-systems/puma_rk3399/puma-rk3399.c
+++ b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
@@ -136,19 +136,3 @@ int misc_init_r(void)
return 0;
  }
-
-#ifdef CONFIG_SERIAL_TAG
-void get_board_serial(struct tag_serialnr *serialnr)
-{
-       char *serial_string;
-       u64 serial = 0;
-
-       serial_string = env_get("serial#");
-
-       if (serial_string)
-               serial = simple_strtoull(serial_string, NULL, 16);
-
-       serialnr->high = (u32)(serial >> 32);
-       serialnr->low = (u32)(serial & 0xffffffff);
-}
-#endif

Reply via email to