On Mon, Sep 26, 2022 at 3:48 AM Sughosh Ganu <sughosh.g...@linaro.org> wrote: > > On Mon, 26 Sept 2022 at 08:22, Jassi Brar <jassisinghb...@gmail.com> wrote: > > > > On Thu, Sep 15, 2022 at 3:16 AM Sughosh Ganu <sughosh.g...@linaro.org> > > wrote: > > > > > diff --git a/drivers/fwu-mdata/Kconfig b/drivers/fwu-mdata/Kconfig > > > new file mode 100644 > > > index 0000000000..7322da48b1 > > > --- /dev/null > > > +++ b/drivers/fwu-mdata/Kconfig > > > @@ -0,0 +1,16 @@ > > > +config FWU_MDATA > > > + bool "Driver support for accessing FWU Metadata" > > > + depends on DM > > > + help > > > + Enable support for accessing FWU Metadata partitions. The > > > + FWU Metadata partitions reside on the same storage device > > > + which contains the other FWU updatable firmware images. > > > + > > > +config FWU_MDATA_GPT_BLK > > > + bool "FWU Metadata access for GPT partitioned Block devices" > > > + select PARTITION_TYPE_GUID > > > + select PARTITION_UUIDS > > > + depends on DM && HAVE_BLOCK_DEVICE && EFI_PARTITION > > > > > It should depend on FWU_MDATA instead of DM. > > Though, eventually it will be a choice between GPT and MTD. > > Yes, this should depend on FWU_MDATA. Will change. > > > > > ... > > > +static int fwu_gpt_mdata_check(struct udevice *dev) > > > +{ > > > + /* > > > + * Check if both the copies of the FWU > > > + * metadata are valid. If one has gone > > > + * bad, restore it from the other good > > > + * copy. > > > + */ > > > > > This comment is repeated 3 more times in the patchset. Maybe get rid > > of this and some other. > > Sorry, I could not find any other comment like this in the file. Can > you point me out where this comment has been repeated. > I said patchset, not file. grep'ing "restore it from the other" in the patches show drivers/fwu-mdata/gpt_blk.c, drivers/fwu-mdata/fwu-mdata-uclass.c and twice in include/fwu.h
Btw, the other three times it says "restore it from the other bad copy" :D -j