On Thu, 1 Sept 2022 at 02:28, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > On 7/22/22 19:43, jassisinghb...@gmail.com wrote:
> >> diff --git a/board/socionext/developerbox/developerbox.c > >> b/board/socionext/developerbox/developerbox.c > >> index f5a5fe0121..ad2260e3d7 100644 > >> --- a/board/socionext/developerbox/developerbox.c > >> +++ b/board/socionext/developerbox/developerbox.c > >> @@ -20,6 +20,13 @@ > >> > >> #if CONFIG_IS_ENABLED(EFI_HAVE_CAPSULE_SUPPORT) > >> struct efi_fw_image fw_images[] = { > >> +#if defined(CONFIG_FWU_MULTI_BANK_UPDATE) > >> + { > >> + .image_type_id = DEVELOPERBOX_FIP_IMAGE_GUID, > >> + .fw_name = u"DEVELOPERBOX-FIP", > > > > The design is flawed. These fields should be moved to the device-tree. > > Currently we are changing C files for each board were we enable firmware > updates. Probably an even better place then the device-tree would be a > Kconfig file. The only problem with Kconfig is that it does not easily > allow to edit arrays. But we could use a string like: > > GUID,name,index,GUID,name,index,... > Probably. But there already exists the structure that this patch only adds an entry to. Moving that structure into dt or kconfig should be a separate task of different context. Also right now I don't want to diverge from gpt based STM's implementation which does the same thing. thanks