Hi Heinrich 

[...]

> > -           return EFI_EXIT(EFI_INVALID_PARAMETER);
> > +           return EFI_INVALID_PARAMETER;
> 
> Please, use a efi_search_obj(handle) to determine if the handle is valid.
> 
>       if (!efi_search_obj(handle))
>               return EFI_INVALID_PARAMETER;

We should only check against NULL here, since we need to add a new handle
if it doesn't exist.  In Uninstall that would make sense, but we already
check that in efi_uninstall_protocol().

[...]


Thanks
/Ilias

Reply via email to