> -----Original Message-----
> From: Lei Wen [mailto:lei...@marvell.com]
> Sent: Monday, January 10, 2011 9:31 AM
> To: u-boot@lists.denx.de; Prafulla Wadaskar; Yu Tang; Ashish Karkare;
> Prabhanjan Sarnaik; adrian . wenl @ gmail . com "
> Subject: [PATCH V2 1/5] mv: seperate kirkwood and armada from common
> setting
> 
> Since there are lots of difference between kirkwood and armada series,
> it is better to seperate them but still keep the most common file
> shared by all marvell platform in the mv-common configure file.
> 
> This patch move the kirkwood only driver definitoin in mv-common to
> the <soc_name>/config.h.
> 
> This patch is tested with compilation for armada100 and guruplug.
> 
> Signed-off-by: Lei Wen <lei...@marvell.com>
> ---
>  arch/arm/include/asm/arch-armada100/config.h |   50 +++++++++
>  arch/arm/include/asm/arch-kirkwood/config.h  |  145
> +++++++++++++++++++++++++
>  include/configs/aspenite.h                   |    1 +
>  include/configs/mv-common.h                  |  147 ++++---------------
...snip...
>  #define CONFIG_DISPLAY_CPUINFO       /* Display cpu info */
>  #define CONFIG_STACKSIZE     0x00100000      /* regular stack- 1M */
> @@ -199,27 +124,32 @@
>  #endif
>  #endif /* CONFIG_NR_DRAM_BANKS */
> 
> +/* ====> Include platform Common Definations */
> +#include <asm/arch/config.h>

I think you should move this include in the beginning, if there is any specific 
arch specific definition that can be used further down in this file.

Rest ack for the rest of the patch.

Regards..
Prafulla . .
 
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to