On Wed, 2022-11-09 at 17:33 +0800, Macpaul Lin wrote: > On 11/9/22 15:32, Macpaul Lin wrote: > > > > On 11/9/22 10:07, Chunfeng Yun (云春峰) wrote: > > > On Tue, 2022-11-08 at 11:21 +0800, Macpaul Lin wrote: > > > > From: Fabien Parent <fpar...@baylibre.com> > > > > > > > > The MediaTek MT8195 is a ARM64-based SoC with a quad-core > > > > Cortex-A73 > > > > and > > > > a quad-core Cortex-A53. It is including UART, SPI, USB3.0 > > > > device and > > > > hosts, > > > > SD and MMC cards, UFS, PWM, I2C, I2S, S/PDIF, and several > > > > LPDDR3 > > > > and LPDDR4 options. > > > > > > > > Signed-off-by: Fabien Parent <fpar...@baylibre.com> > > > > Signed-off-by: Macpaul Lin <macpaul....@mediatek.com> > > > > --- > > > > MAINTAINERS | 2 + > > > > arch/arm/dts/mt8195.dtsi | 317 > > > > +++++++++++++++++++++++++ > > > > arch/arm/mach-mediatek/Kconfig | 13 +- > > > > arch/arm/mach-mediatek/Makefile | 1 + > > > > arch/arm/mach-mediatek/mt8195/Makefile | 3 + > > > > arch/arm/mach-mediatek/mt8195/init.c | 81 +++++++ > > > > 6 files changed, 416 insertions(+), 1 deletion(-) > > > > create mode 100644 arch/arm/dts/mt8195.dtsi > > > > create mode 100644 arch/arm/mach-mediatek/mt8195/Makefile > > > > create mode 100644 arch/arm/mach-mediatek/mt8195/init.c > > [deleted] > > > > > + xhci3: xhci3@112b0000 { > > > > > > change node name as xhci? prefer to use the same name > > > > > > > Since there are other board manufacturers will use the > > other HOST ports, like xhci1 or xhci2 with USB mass storage > > function by their needs. > > I'll add these 2 node in dtsi in next version. > > > > > > + compatible = "mediatek,mt8195-xhci", > > > > + "mediatek,mtk-xhci"; > > > > + reg = <0 0x112b0000 0 0x1000>, > > > > + <0 0x112b3e00 0 0x0100>; > > > > + reg-names = "mac", "ippc"; > > > > > > remove "mac" > > > > Will fix it in next version. > > > > Dear Chunfeng, > > Unfortunately, if we remove "mac" register here for HOST only node > like > xhci3, the driver will complain about probing fail. Please check the > following log. My bad, do need it for host only mode, sorry
> > => usb start > starting USB... > Bus xhci3@112b0000: xhci-mtk xhci3@112b0000: failed to get xHCI base > address > probe failed, error -6 > No working controllers found > > I'll add "mac" back to HOST only nodes. > > Thanks! > Macpaul Lin