On Wednesday 09 November 2022 19:14:40 Simon Glass wrote: > This currently uses if_changed on a phony target. Use a real file as the > target and add FORCE at the end, as required. Drop the 'inputs' phony > since it is not needed.
Hello! Just one small note. It is quite surprising that .buildman_stamp target is called also when CONFIG_BINMAN is disabled. Not sure if this is expected but seems it should not cause any issue. > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > (no changes since v2) > > Changes in v2: > - Use a separate rule for running binman > > Makefile | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/Makefile b/Makefile > index d6699a54dbb..93d5c064f4c 100644 > --- a/Makefile > +++ b/Makefile > @@ -1108,18 +1108,15 @@ define deprecated > > endef > > -PHONY += inputs > -inputs: $(INPUTS-y) > - > -all: .binman_stamp inputs > +# Timestamp file to make sure that binman always runs > +.binman_stamp: $(INPUTS-y) FORCE > ifeq ($(CONFIG_BINMAN),y) > $(call if_changed,binman) > endif > - > -# Timestamp file to make sure that binman always runs > -.binman_stamp: FORCE > @touch $@ > > +all: .binman_stamp > + > ifeq ($(CONFIG_DEPRECATED),y) > $(warning "You have deprecated configuration options enabled in your > .config! Please check your configuration.") > endif > -- > 2.38.1.431.g37b22c650d-goog >