On Jan 11, 2011, at 1:09 AM, Wolfgang Denk wrote: > Dear Kumar Gala, > > In message <1294607813-27723-1-git-send-email-ga...@kernel.crashing.org> you > wrote: >> Moved the SRIO init out of corenet_ds and into common code for >> 8xxx/QorIQ processors that have SRIO. We mimic what we do with PCIe >> controllers for SRIO. >> >> We utilize the fact that SRIO is over serdes to determine if its >> configured or not and thus can setup the LAWs needed for it dynamically. >> >> We additionally update the device tree (to remove the SRIO nodes) if the >> board doesn't have SRIO enabled. >> >> Introduced the following standard defines for board config.h: >> >> CONFIG_SYS_HAS_SRIO - Chip has SRIO or not > > We don't use a "CONFIG_SYS_HAS_*" normally; can we use plain > CONFIG_SYS_SRIO instead? (yes, I am aware of the > CONFIG_SYS_HAS_SERDES precedent, which escaped my attantion during > review - that should be fixed, too). > >> CONFIG_SRIO1 - Board has SRIO 1 port available >> CONFIG_SRIO2 - Board has SRIO 2 port available >> >> (where 'n' is the port #) >> CONFIG_SYS_SRIOn_MEM_VIRT - virtual address in u-boot >> CONFIG_SYS_SRIOn_MEM_PHYS - physical address (for law setup) >> CONFIG_SYS_SRIOn_MEM_SIZE - size of window (for law setup) > > These need to be documented (README).
Changes made, please ACK the first patch in the series. - k _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot