On Tue, 11 Jan 2011 19:51:41 +0800
Baidu Boy <liucai....@gmail.com> wrote:
> Hi, Scott
>
> 2011/1/11 Scott Wood <scottw...@freescale.com>:
> > On Mon, 10 Jan 2011 20:42:28 +0800
> > Baidu Boy <liucai....@gmail.com> wrote:
> >
> >> This patch fix a problem for the pcie enumeration when the mpc83xx pcie
> >> controller is
> >> connected with switch or we use both of the two pcie controller
> >>
> >> Signed-off-by: Baidu Boy <liucai....@gmail.com>
> >> ---
> >> Changes for V2:
> >> - Avoid line wrap in the patch
> >> Changes for V3
> >> - Add space between ) and {
> >
> > What about my comments?
> >
> > http://lists.denx.de/pipermail/u-boot/2011-January/084758.html
> >
>
> Actually, Your suggestion is better. But it will touch the common
> structure pci_controller.
That's OK, it's been touched by other PCI implementations too. Ideally
these custom fields would be replaced by a private-data pointer.
> And I just want to make the change only in the mpc83xx.
Don't be afraid to refactor at a larger scale when needed.
Your current approach only works during initial scanning. It won't
work if config accesses are done later.
-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
