On Fri, Oct 14, 2022 at 07:43:42PM +0200, Rasmus Villemoes wrote: > U-Boot does not support IP fragmentation on TX (and unless > CONFIG_IP_DEFRAG is set, neither on RX). So the blocks we send must > fit in a single ethernet packet. > > Currently, if tftpblocksize is set to something like 5000 and I > tftpput a large enough file, U-Boot crashes because we overflow > net_tx_packet (which only has room for 1500 bytes plus change). > > Similarly, if tftpblocksize is set to something larger than what we > can actually receive (e.g. 50000, with NET_MAXDEFRAG being 16384), any > tftp get just hangs because we never receive any packets. > > Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk> > Reviewed-by: Ramon Fried <rfried....@gmail.com>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
