Hello, On Sun, Dec 18, 2022 at 06:00:13PM +0800, Kever Yang wrote: > Hi Quentin, > > I would prefer you to remove SPL_ATF_NO_PLATFORM_PARAM in those boards > you have test,
then we will have no end of this problem. > > there may have some boards using legacy ATF binary but still want to use > mainline U-Boot Why would they do it? The ATF is SoC-specific, the only board-specific part is the console speed which is resolved by this change. If people are using old kernel because they have binary driver for a special device they can still change the option in the kconfig. Maybe adding a note in the rk3399 documentation woukl be dessirable but that's about it. Thanks Michal > > which may have problem with this update. > > > Thanks, > > - Kever > > On 2022/11/15 01:37, Quentin Schulz wrote: > > From: Quentin Schulz <quentin.sch...@theobroma-systems.com> > > > > Long are gone the times TF-A couldn't handle the FDT passed by U-Boot. > > Specifically, since commit e7b586987c0a ("rockchip: don't crash if we > > get an FDT we can't parse") in TF-A, failure to parse the FDT will use > > the fallback mechanism. This patch was merged in TF-A v2.4-rc0 from two > > years ago. > > > > Therefore, let's finally pass the FDT to TF-A so that it can get the > > serial configuration from U-Boot FDT instead of requiring the user to > > patch TF-A hardcoded fallback values. > > > > Cc: Quentin Schulz <foss+ub...@0leil.net> > > Signed-off-by: Quentin Schulz <quentin.sch...@theobroma-systems.com> > > --- > > rockchip: rk3399: pass platform parameter to TF-A > > > > Finally pass the FDT address to TF-A since it now gracefully fallbacks to > > hardcoded defaults if it cannot parse it. This allows us to avoid modifying > > hardcoded values in TF-A to enable the console. > > > > This was tested with TF-A v2.7.0 on Puma Haikou RK3399. > > > > To: Simon Glass <s...@chromium.org> > > To: Philipp Tomsich <philipp.toms...@vrull.eu> > > To: Kever Yang <kever.y...@rock-chips.com> > > Cc: Hugh Cole-Baker <sigma...@gmail.com> > > Cc: Walter Lozano <walter.loz...@collabora.com> > > Cc: u-boot@lists.denx.de > > --- > > arch/arm/mach-rockchip/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > > index 69d51ff378..2fcc23f9fa 100644 > > --- a/arch/arm/mach-rockchip/Kconfig > > +++ b/arch/arm/mach-rockchip/Kconfig > > @@ -249,7 +249,6 @@ config ROCKCHIP_RK3399 > > imply PRE_CONSOLE_BUFFER > > imply ROCKCHIP_COMMON_BOARD > > imply ROCKCHIP_SDRAM_COMMON > > - imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF > > imply SPL_ROCKCHIP_COMMON_BOARD > > imply TPL_SERIAL > > imply TPL_LIBCOMMON_SUPPORT > > > > --- > > base-commit: 0cbeed4f6648e0e4966475e3544280a69ecb59d3 > > change-id: 20221114-rk3399-tf-a-plat-param-3ab055f40b9e > > > > Best regards,