-----Original Message----- From: Heinrich Schuchardt <xypron.g...@gmx.de> Sent: Friday, September 9, 2022 1:10 AM To: Kshitiz Varshney <kshitiz.varsh...@nxp.com> Cc: Stefano Babic <sba...@denx.de>; Fabio Estevam <feste...@gmail.com>; Peng Fan <peng....@nxp.com>; Sughosh Ganu <sughosh.g...@linaro.org>; u-boot@lists.denx.de; Ye Li <ye...@nxp.com>; Gaurav Jain <gaurav.j...@nxp.com>; Rahul Kumar Yadav <rahulkumar.ya...@nxp.com>; Vabhav Sharma <vabhav.sha...@nxp.com>; Varun Sethi <v.se...@nxp.com>; Sahil Malhotra <sahil.malho...@nxp.com>; Pankaj Gupta <pankaj.gu...@nxp.com>; Horia Geanta <horia.gea...@nxp.com> Subject: [EXT] Re: [PATCH v1] 1: Adding rngb entry in imx6ull device tree
Caution: EXT Email On 9/8/22 10:57, Kshitiz Varshney wrote: > From: Kshitiz <kshitiz.varsh...@nxp.com> If you use format-patch HEAD~3, it will add numbers to the patches as expected: [PATCH 1/3]. For patch series we typically generate a cover-letter. Will take care in next patch set. > > Added entry for rngb in imx6ull device tree which is required for > Random number generation in u-boot. > > Signed-off-by: Kshitiz Varshney <kshitiz.varsh...@nxp.com> > Reviewed-by: Ye Li <ye...@nxp.com> > --- > arch/arm/dts/imx6ull.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi > index 46e7ad6bab..c5d5a5ab7b 100644 > --- a/arch/arm/dts/imx6ull.dtsi > +++ b/arch/arm/dts/imx6ull.dtsi > @@ -66,6 +66,12 @@ > clocks = <&clks IMX6ULL_CLK_DCP_CLK>; > clock-names = "dcp"; > }; > + rngb: rng@2284000 { > + compatible = "fsl,imx6ull-rngb", > "fsl,imx25-rngb"; > + reg = <0x02284000 0x4000>; > + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6UL_CLK_DUMMY>; > + }; This seems to match Linux' arch/arm/boot/dts/imx6ull.dtsi and Documentation/devicetree/bindings/rng/imx-rng.yaml. As, this node entry is already present in upstream uboot. Hence, removed this patch from new patchset. Acked-by: Heinrich Schuchardt <xypron.g...@gmx.de> > > iomuxc_snvs: iomuxc-snvs@2290000 { > compatible = "fsl,imx6ull-iomuxc-snvs";