On Wednesday 28 December 2022 19:11:34 Tom Rini wrote: > On Wed, Dec 28, 2022 at 07:18:39PM +0100, Pali Rohár wrote: > > U-Boot build system builds final U-Boot binary for socrates board in custom > > file u-boot-socrates.bin (instead of standard u-boot.bin). Output target > > file u-boot-socrates.bin is generated by binman as defined in board binman > > config file arch/powerpc/dts/socrates-u-boot.dtsi. > > > > But binman was disabled in commit 5af42eafd7e1 ("Makefile: Reduce usage of > > custom mpc85xx u-boot.bin target") for all mpc85xx boards which do not use > > standard powerpc binman config file arch/powerpc/dts/u-boot.dtsi and boards > > which do not require binman at all. > > > > The only such mpc85xx board is socrates. So since that commit, U-Boot does > > not final binary for socrates board anymore. > > > > Fix this issue by re-enabling binman for socrates board. And build process > > starts again producing u-boot-socrates.bin binary. > > > > Note that build process for this socrates board always produce u-boot.bin > > binary which is broken and not usable for socrates board. Long term > > solution should be to disable building broken binary u-boot.bin and then > > renaming u-boot-socrates.bin to u-boot.bin, or switching to use common > > powerpc binman config file arch/powerpc/dts/socrates-u-boot.dtsi (if it is > > possible). > > > > Fixes: 5af42eafd7e1 ("Makefile: Reduce usage of custom mpc85xx u-boot.bin > > target") > > Signed-off-by: Pali Rohár <p...@kernel.org> > > --- > > Heiko Schocher: Could you test if u-boot is still working on this board? > > > > Tom Rini: Cannot be this issue handled by CI? For example that CI check > > build process produce required output binaries? > > So, in so far as CI can check for something like this, it does when we > enable it (akin to the build time size checks). I think in this case, > some settings for CONFIG_BUILD_TARGET would help.
Good point about CONFIG_BUILD_TARGET, but it works only for make targets. Not for custom binman target about which make does not know. Anyway, in additional patch I sent change which stops building of u-boot.bin and rename u-boot-socrates.bin to u-boot.bin.