Dear Xiangfu Liu,
In message <1294589925-32639-3-git-send-email-xian...@openmobilefree.net> you
wrote:
> Signed-off-by: Xiangfu Liu <xian...@openmobilefree.net>
> Acked-by: Daniel <z...@ingenic.cn>
> Acked-by: ChangWei Jia <cw...@ingenic.cn>
>
> ---
> arch/mips/include/asm/jz4740.h | 1380
> ++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 1380 insertions(+), 0 deletions(-)
> create mode 100644 arch/mips/include/asm/jz4740.h
Description of changes against previous version missing.
...
> +/*
> + * INTC (Interrupt Controller)
> + */
> +#define INTC_ISR (INTC_BASE + 0x00)
> +#define INTC_IMR (INTC_BASE + 0x04)
> +#define INTC_IMSR (INTC_BASE + 0x08)
> +#define INTC_IMCR (INTC_BASE + 0x0c)
> +#define INTC_IPR (INTC_BASE + 0x10)
NAK. Please use a C struct instead.
...
> +/*
> + * RTC
> + */
> +#define RTC_RCR (RTC_BASE + 0x00) /* RTC Control Register */
> +#define RTC_RSR (RTC_BASE + 0x04) /* RTC Second Register */
> +#define RTC_RSAR (RTC_BASE + 0x08) /* RTC Second Alarm Register */
> +#define RTC_RGR (RTC_BASE + 0x0c) /* RTC Regulator Register */
> +
> +#define RTC_HCR (RTC_BASE + 0x20) /* Hibernate Control Register
> */
> +#define RTC_HWFCR (RTC_BASE + 0x24) /* Hibernate Wakeup Filter Counter
> Reg */
> +#define RTC_HRCR (RTC_BASE + 0x28) /* Hibernate Reset Counter Register */
> +#define RTC_HWCR (RTC_BASE + 0x2c) /* Hibernate Wakeup Control Register
> */
> +#define RTC_HWRSR (RTC_BASE + 0x30) /* Hibernate Wakeup Status Register */
> +#define RTC_HSPR (RTC_BASE + 0x34) /* Hibernate Scratch Pattern Register
> */
Ditto. Use C structs.
I stop my review here. There are too many global issues that need to
be fixed first.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
It is dangerous to be sincere unless you are also stupid.
- George Bernard Shaw
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
