On Jan 9, 2011, at 2:29 PM, Kumar Gala wrote: > There are several users of the hwconfig APIs (8xxx DDR) before we have > the environment properly setup. This causes issues because of the > numerous ways the environment might be accessed because of the > non-volatile memory it might be stored in. Additionally the access > might be so early that memory isn't even properly setup for us. > > Towards resolving these issues we provide versions of all the hwconfig > APIs that can be passed in a buffer to parse and leave it to the caller > to determine how to allocate and populate the buffer. > > We use the _f naming convention for these new APIs even though they are > perfectly useable after relocation and the environment being ready. > > We also now warn if the non-f APIs are called before the environment is > ready to allow users to address the issues. > > Finally, we convert the 8xxx DDR code to utilize the new APIs to > hopefully address the issue once and for all. We have the 8xxx DDR code > create a buffer on the stack and populate it via getenv_f(). > > Signed-off-by: Kumar Gala <ga...@kernel.crashing.org> > --- > * Add a comment about the buffer size > arch/powerpc/cpu/mpc8xxx/ddr/options.c | 78 ++++++++++++++++++++++------- > common/hwconfig.c | 86 +++++++++++++++++--------------- > include/hwconfig.h | 68 +++++++++++++++++++------ > 3 files changed, 155 insertions(+), 77 deletions(-)
Wolfgang, Reminder to take a look at this patch. Its a precursor to York's DDR cleanup patches. - k _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot