On Mon, Jan 16, 2023 at 05:21:35PM +0530, Nikhl M Jain wrote:
>
>
> On 13/01/23 20:13, Tom Rini wrote:
> > On Fri, Jan 13, 2023 at 01:59:25PM +0530, Nikhil M Jain wrote:
> >
> > > Set splash screen related env variables. Default
> > > splash source is set to mmc where user is expected
> > > to keep bmp in compressed format with name ti.gz
> > > on first partition of mmc.
> > >
> > > Splash file will be uncompressed to DDR at address
> > > 0x82000000 and splash position is set to middle of
> > > screen.
> > >
> > > Signed-off-by: Nikhil M Jain <n-ja...@ti.com>
> > > ---
> > > include/configs/am62x_evm.h | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/configs/am62x_evm.h b/include/configs/am62x_evm.h
> > > index 78201adc07..acbcfe0526 100644
> > > --- a/include/configs/am62x_evm.h
> > > +++ b/include/configs/am62x_evm.h
> > > @@ -29,7 +29,11 @@
> > > "console=ttyS2,115200n8\0"
> > > \
> > > "args_all=setenv optargs ${optargs}
> > > earlycon=ns16550a,mmio32,0x02800000 " \
> > > "${mtdparts}\0"
> > > \
> > > - "run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr}\0"
> > > + "run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr}\0" \
> > > + "splashsource=mmc\0" \
> > > + "splashfile=ti.gz\0" \
> > > + "splashimage=0x82000000\0" \
> > > + "splashpos=m,m\0" \
> >
> > Can we please convert this board to plain text environment and then add
> > more?
> >
> Are you suggesting to move all the env settings done in this file into a
> separate bootscript text file (as done in
> board/boundary/nitrogen6x/6x_bootscript.txt ) which user needs to import
> using env import commnand or have it as a bootscript?
>
> My preference was to append new env settings to am62x_evm.h itself, to avoid
> extra step to import environment or run a boot script and have faster boot.No, I'm saying you should move this in to a plain text environment similar to board/qualcomm/dragonboard410c/dragonboard410c.env or for more complex examples, board/keymile/*/*.env. -- Tom
signature.asc
Description: PGP signature
