Hi Safae, On Fri, 27 Jan 2023 at 08:50, Safae Ouajih <soua...@baylibre.com> wrote: > > > On 27/01/2023 01:54, Simon Glass wrote: > > Hi Safae, > > > > On Thu, 26 Jan 2023 at 09:05, Safae Ouajih <soua...@baylibre.com> wrote: > >> Move from andr_boot_img_hdr_v0 to andr_image_data > >> structure to prepare for boot image header > >> version 3 and 4. > >> > >> Signed-off-by: Safae Ouajih <soua...@baylibre.com> > >> --- > >> boot/image-android.c | 127 ++++++++++++++++++++++++------------------- > >> cmd/abootimg.c | 31 ++++++----- > >> include/image.h | 2 + > >> 3 files changed, 89 insertions(+), 71 deletions(-) > >> > > Do you need the #ifdef CONFIG_CMD_ABOOTIMG? We try to avoid adding those. > > > > Regards, > > Simon > > Hi Simon, > > This is needed to avoid warnings such as "unused function warnings" when > > CONFIG_CMD_ABOOTIMG is not defined.
It is quite rare that this is needed and I cannot see it myself. Can you please check again? You should call the function from an IS_ENABLED() check, not an #ifdef. Also, if it is in another file there is no need to #ifdef it since it will just be dropped by the linker. Regards, Simon