On Sun, Feb 12, 2023 at 12:08 PM Tom Rini <tr...@konsulko.com> wrote: > > On Sun, Feb 12, 2023 at 12:02:26PM -0600, Adam Ford wrote: > > On Sun, Feb 12, 2023 at 11:47 AM Tom Rini <tr...@konsulko.com> wrote: > > > > > > On Sun, Feb 12, 2023 at 11:36:38AM -0600, Adam Ford wrote: > > > > > > > Beacon Embedded has an i.MX8M Plus development kit which consists > > > > of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, > > > > and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual > > > > Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet > > > > PHY. The device trees are already queued for inclusion in Linux 6.3. > > > > > > > > Signed-off-by: Adam Ford <aford...@gmail.com> > > > [snip] > > > > diff --git a/board/beacon/imx8mp/README b/board/beacon/imx8mp/README > > > > new file mode 100644 > > > > index 0000000000..47999bb038 > > > > --- /dev/null > > > > +++ b/board/beacon/imx8mp/README > > > > > > Our rST docs have gotten to the point I think where we should say no to > > > new board README files, this belongs under doc/board/ > > > > OK. I'll work on that. > > > > > > > > [snip] > > > > +#define CFG_EXTRA_ENV_SETTINGS \ > > > > + "scriptaddr=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ > > > > + "kernel_addr_r=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ > > > > + "image=Image\0" \ > > > > + "console=ttymxc1,115200\0" \ > > > > + "fdt_addr_r=0x43000000\0" \ > > > > + "fdt_addr=0x43000000\0" \ > > > > + "boot_fdt=try\0" \ > > > > + "boot_fit=no\0" \ > > > > + "fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \ > > > > + "bootm_size=0x10000000\0" \ > > > > + "mmcdev=1\0" \ > > > > + "mmcpart=1\0" \ > > > > + "optargs=audit=0 video=LVDS-1:d video=LVDS-2:d\0" \ > > > > + "finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \ > > > > + "mmcargs=setenv bootargs console=${console} " \ > > > > + " root=PARTUUID=${uuid} rootwait rw ${mtdparts} ${optargs}\0" \ > > > > + "bootscript=echo Running bootscript from mmc ...; " \ > > > > + "source\0" \ > > > > + "loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} > > > > ${image}\0" \ > > > > + "loadfdt=echo ${fdt_file}; fatload mmc ${mmcdev}:${mmcpart} > > > > ${fdt_addr_r} ${fdt_file}\0" \ > > > > + "mmcboot=echo Booting from mmc ...; " \ > > > > + "run finduuid; run mmcargs; " \ > > > > + "if test ${boot_fit} = yes || test ${boot_fit} = try; > > > > then " \ > > > > + "bootm ${loadaddr}; " \ > > > > + "else " \ > > > > + "if run loadfdt; then " \ > > > > + "booti ${loadaddr} - ${fdt_addr_r}; " \ > > > > + "else " \ > > > > + "echo WARN: Cannot load the DT; " \ > > > > + "fi; " \ > > > > + "fi;\0" \ > > > > + "netargs=setenv bootargs ${jh_clk} console=${console} " \ > > > > + "root=/dev/nfs " \ > > > > + "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \ > > > > + "netboot=echo Booting from net ...; " \ > > > > + "run netargs; " \ > > > > + "if test ${ip_dyn} = yes; then " \ > > > > + "setenv get_cmd dhcp; " \ > > > > + "else " \ > > > > + "setenv get_cmd tftp; " \ > > > > + "fi; " \ > > > > + "${get_cmd} ${loadaddr} ${image}; " \ > > > > + "if test ${boot_fit} = yes || test ${boot_fit} = try; > > > > then " \ > > > > + "bootm ${loadaddr}; " \ > > > > + "else " \ > > > > + "if ${get_cmd} ${fdt_addr_r} ${fdt_file}; then " \ > > > > + "booti ${loadaddr} - ${fdt_addr_r}; " \ > > > > + "else " \ > > > > + "echo WARN: Cannot load the DT; " \ > > > > + "fi; " \ > > > > + "fi;\0" > > > > > > And this should all be plain text environment (see board/*/*/*.env for > > > > I didn't even know this was a thing, but after reviewing what others > > are doing, I like this much better. > > That's good to hear. > > > > examples), and please put it somewhere on your TODO list to migrate > > > other platforms README and environments, thanks! > > > > Is there a deadline? > > Neither has a firm deadline at this point, thanks!
Tom, I pushed a V2 and CC'd you. If you're OK with both the env file and the rst file for this board, I'll do the same thing for the other Beacon and LogicPD boards. I just don't want to do the work until I know my first attempt at these new files is acceptable. Thanks, adam > > -- > Tom