сб, 18 февр. 2023 г. в 02:49, Simon Glass <s...@chromium.org>:
>
> Hi Dzmitry,
>
> On Fri, 17 Feb 2023 at 08:01, Dzmitry Sankouski <dsankou...@gmail.com> wrote:
> >
> > - move common code to vidconsole_internal.h
> > - unite probe functions
> > - get rid of code duplications in switch across bpp values
> > - extract common pixel fill logic in two functions one per
> > horizontal and vertical filling
> > - rearrange statements in put_xy* methods in unified way
> > - replace types - uint*_t to u*
> >
> > Signed-off-by: Dzmitry Sankouski <dsankou...@gmail.com>
> > ---
> > Changes for v2: none
> > Changes for v3: none
> > Changes for v4:
> > - move common code to vidconsole_internal.h
> > - unite probe functions
> >
> > drivers/video/console_normal.c | 150 +++---------
> > drivers/video/console_rotate.c | 364 ++++++++--------------------
> > drivers/video/vidconsole_internal.h | 148 +++++++++++
> > 3 files changed, 288 insertions(+), 374 deletions(-)
> > create mode 100644 drivers/video/vidconsole_internal.h
>
> Can you put the actual code from the shared functions in
> vidconsole-uclass.c - that way it won't be compiled in twice into
> those two files.
>
I think vidconsole-uclass.c is a bad place for driver internals.
I'll put shared functions in a separate file.
>
>
(...)
