On Wed, Feb 22, 2023 at 10:13 AM Troy Kisky <troykiskybound...@gmail.com> wrote:
> On Wed, Feb 22, 2023 at 8:59 AM Tom Rini <tr...@konsulko.com> wrote: > >> On Tue, Feb 21, 2023 at 05:38:15PM -0800, Troy Kisky wrote: >> >> > setup_sata is linked with >> > obj-$(CONFIG_SATA) += sata.o >> > >> > So use SATA instead of CMD_SATA. >> > >> > Signed-off-by: Troy Kisky <troykiskybound...@gmail.com> >> > --- >> > >> > board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c >> b/board/solidrun/mx6cuboxi/mx6cuboxi.c >> > index 7c44379ec4a..e31a7e9552f 100644 >> > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c >> > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c >> > @@ -275,7 +275,7 @@ int board_early_init_f(void) >> > { >> > setup_iomux_uart(); >> > >> > -#ifdef CONFIG_CMD_SATA >> > +#if CONFIG_IS_ENABLED(SATA) >> > setup_sata(); >> > #endif >> > setup_fec(); >> >> Note that wandboard needs a similar fix. >> >> -- >> Tom >> > > Hi Tom > > The commit script will change > #ifdef CONFIG_SATA > > to > #if CONFIG_IS_ENABLED(SATA) > > This series only changes things that the commit script won't. > > BR > Troy > You are right Tom, wandboard is needed too as it uses SPL. I don't know how it passed CI last time. But it didn't this time. BR Troy