On Sat, 25 Feb 2023 at 12:01, Jonas Karlman <jo...@kwiboo.se> wrote: > > Using the mkimage entry with the multiple-data-files prop and having a > missing external blob result in an unexpected ValueError exception using > the --allow-missing flag. > > ValueError: Filename 'missing.bin' not found in input path (...) > > Fix this by using _pathname that is resolved by ObtainContents for blob > entries, ObtainContents also handles allow missing for external blobs. > > Mark mkimage entry as missing and return without running mkimage when > missing entries is reported by CheckMissing. > > Signed-off-by: Jonas Karlman <jo...@kwiboo.se> > --- > v5: > - New patch based on [1] > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/20230219220158.4160763-7-jo...@kwiboo.se/ > > tools/binman/etype/mkimage.py | 24 ++++++++++++++++++- > tools/binman/ftest.py | 11 +++++++++ > .../test/278_mkimage_missing_multiple.dts | 19 +++++++++++++++ > 3 files changed, 53 insertions(+), 1 deletion(-) > create mode 100644 tools/binman/test/278_mkimage_missing_multiple.dts
Reviewed-by: Simon Glass <s...@chromium.org>