On Mon, Feb 27, 2023 at 11:51:30PM +0100, Marek Vasut wrote: > Copy build artifacts for all test.py tests, so they show up in > artifacts storage for later inspection. The test.py tests output > in CI is basically useless, but it is far more useful in the html > output for analysis and debugging. > > Suggested-by: Simon Glass <s...@chromium.org> > Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org> > --- > Cc: Simon Glass <s...@chromium.org> > Cc: Tom Rini <tr...@konsulko.com> > --- > .gitlab-ci.yml | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 272d69e2206..1b761f26e9a 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -77,9 +77,12 @@ stages: > ${TEST_PY_TEST_SPEC:+"-k ${TEST_PY_TEST_SPEC}"} > --build-dir "$UBOOT_TRAVIS_BUILD_DIR" > # It seems that the files in /tmp go away, so copy out what we need
We can drop this comment. > - - if [[ "${TEST_PY_BD}" == "coreboot" ]]; then > - cp -v /tmp/coreboot/*.{html,css} .; > - fi > + - cp -v /tmp/${TEST_PY_BD}/*.{html,css} . > + artifacts: > + paths: > + - "*.html" > + - "*.css" > + expire_in: 1 week > > build all 32bit ARM platforms: > stage: world build > @@ -454,9 +457,4 @@ coreboot test.py: > TEST_PY_BD: "coreboot" > TEST_PY_TEST_SPEC: "not sleep" > TEST_PY_ID: "--id qemu" > - artifacts: > - paths: > - - "*.html" > - - "*.css" > - expire_in: 1 week > <<: *buildman_and_testpy_dfn So, what looks like a debugging artifact was included in the proper patch and merged, and yes, https://u-boot.source-pages.denx.de/-/u-boot/-/jobs/585388/artifacts/test-log.html is quite handy in the case of test failure. Reviewed-by: Tom Rini <tr...@konsulko.com> -- Tom
signature.asc
Description: PGP signature