On 02.03.23 00:38, Simon Glass wrote: > Hi Jan, > > On Tue, 28 Feb 2023 at 11:20, Jan Kiszka <jan.kis...@siemens.com> wrote: >> >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> Anything that is not boot-env related is better kept there by now. >> >> At this chance, also drop a stale comment from iot2050.h >> >> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> >> --- >> board/siemens/iot2050/iot2050.env | 9 +++++++++ >> include/configs/iot2050.h | 11 ++--------- >> 2 files changed, 11 insertions(+), 9 deletions(-) >> create mode 100644 board/siemens/iot2050/iot2050.env >> >> diff --git a/board/siemens/iot2050/iot2050.env >> b/board/siemens/iot2050/iot2050.env >> new file mode 100644 >> index 00000000000..4bd93f0b2f4 >> --- /dev/null >> +++ b/board/siemens/iot2050/iot2050.env >> @@ -0,0 +1,9 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * Copyright (c) Siemens AG, 2023 >> + * >> + * Authors: >> + * Jan Kiszka <jan.kis...@siemens.com> >> + */ >> + >> +usb_pgood_delay=900 >> diff --git a/include/configs/iot2050.h b/include/configs/iot2050.h >> index cfff46ce339..8dfeaddf541 100644 >> --- a/include/configs/iot2050.h >> +++ b/include/configs/iot2050.h >> @@ -13,12 +13,6 @@ >> >> #include <linux/sizes.h> >> >> -/* SPL Loader Configuration */ >> - >> -/* U-Boot general configuration */ >> -#define EXTRA_ENV_IOT2050_BOARD_SETTINGS \ >> - "usb_pgood_delay=900\0" >> - >> #if IS_ENABLED(CONFIG_CMD_USB) >> # define BOOT_TARGET_USB(func) \ >> func(USB, usb, 0) \ >> @@ -40,10 +34,9 @@ >> >> #include <config_distro_bootcmd.h> >> >> -#define CFG_EXTRA_ENV_SETTINGS \ >> +#define CFG_EXTRA_ENV_SETTINGS \ >> DEFAULT_LINUX_BOOT_ENV \ >> - BOOTENV \ >> - EXTRA_ENV_IOT2050_BOARD_SETTINGS >> + BOOTENV >> >> #include <configs/ti_armv7_common.h> >> >> -- >> 2.35.3 >> > > You might want to move to standard boot so you can use a text-based > environment. See for example [1] [2] and later patches from [3]. >
Err, this patch is about introducing a text-based env for the parts that can be moved. I don't see a relevant delta after this patch to the referenced examples (btw, [2] is missing). Jan > Regards, > Simon > > [1] https://patchwork.ozlabs.org/project/uboot/list/?series=342718 > [2] > [3] from > https://patchwork.ozlabs.org/project/uboot/list/?series=338993&state=* -- Siemens AG, Technology Competence Center Embedded Linux