On Tue, Mar 7, 2023 at 11:53 AM Mark Kettenis <mark.kette...@xs4all.nl> wrote:
> That is probably the wrong approach. It should be possible to boot an > OS with the device tree provided by U-Boot. Removing these properties > means the OS doesn't see them either. But if the assigned-clocks > property isn't needed it wouldn't be there would it? Well, should we revert 5bec4b0de785 in this case? > > commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 > > assigned-clocks/rates") > > dropped these properties for combphy1, so let's drop them for combphy0 as > > well. > > > > Signed-off-by: Vasily Khoruzhick <anars...@gmail.com> > > --- > > arch/arm/dts/rk3568-evb-u-boot.dtsi | 1 + > > arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 1 + > > arch/arm/dts/rk3568-u-boot.dtsi | 11 +++++++++++ > > 3 files changed, 13 insertions(+) > > create mode 100644 arch/arm/dts/rk3568-u-boot.dtsi > > > > diff --git a/arch/arm/dts/rk3568-evb-u-boot.dtsi > > b/arch/arm/dts/rk3568-evb-u-boot.dtsi > > index 17503d3d27..77430da3ba 100644 > > --- a/arch/arm/dts/rk3568-evb-u-boot.dtsi > > +++ b/arch/arm/dts/rk3568-evb-u-boot.dtsi > > @@ -4,6 +4,7 @@ > > */ > > > > #include "rk356x-u-boot.dtsi" > > +#include "rk3568-u-boot.dtsi" > > > > / { > > chosen { > > diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > > b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > > index ed47efa44b..44cf33ed4b 100644 > > --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > > +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > > @@ -5,6 +5,7 @@ > > */ > > > > #include "rk356x-u-boot.dtsi" > > +#include "rk3568-u-boot.dtsi" > > > > / { > > chosen { > > diff --git a/arch/arm/dts/rk3568-u-boot.dtsi > > b/arch/arm/dts/rk3568-u-boot.dtsi > > new file mode 100644 > > index 0000000000..c6776666df > > --- /dev/null > > +++ b/arch/arm/dts/rk3568-u-boot.dtsi > > @@ -0,0 +1,11 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (c) 2023 Vasily Khoruzhick <anars...@gmail.com> > > + */ > > + > > +#include "rockchip-u-boot.dtsi" > > + > > +&combphy0 { > > + /delete-property/ assigned-clocks; > > + /delete-property/ assigned-clock-rates; > > +}; > > -- > > 2.39.2 > > > >