Hi Andy, On 3/15/23 14:26, andy...@sony.com wrote: > Hi Jaehoon > >> commit 4a3ea75de4c5b3053eac326bf1c753ed65df8cb9 >> Author: yuezhang...@sony.com <yuezhang...@sony.com> >> Date: Wed Mar 17 06:44:37 2021 +0000 >> >> Revert "mmc: sdhci: set to INT_DATA_END when there are data" >> >> This reverts commit 17ea3c862865c0d704646f67dbf8412f9ff54f59. >> >> Revert the above commit. >> >> To Andy, >> >> Was there any problem without above commit? > > Without above revert commit, we found "sdhci_transfer_data: Transfer data > timeout" on db410c board with v2018.01.
Thanks for sharing it. I had been trying to find db410c board. I found its board, so I will try to check with/without its patch. After checked, I will reply again ASAP. Best Regards, Jaehoon Chung > > Best Regards > Andy Wu > >> -----Original Message----- >> From: Jaehoon Chung <jh80.ch...@gmail.com> >> Sent: Monday, March 13, 2023 9:03 PM >> To: Henrik Grimler <hen...@grimler.se>; Jaehoon Chung >> <jh80.ch...@samsung.com> >> Cc: jo...@diskos.nl; peng....@nxp.com; Wu, Andy <andy...@sony.com>; >> s...@chromium.org; u-boot@lists.denx.de; >> ~postmarketos/upstream...@lists.sr.ht >> Subject: Re: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the >> SDHCI_QUIRK_BROKEN_R1B" >> >> Hi, >> >> On 3/11/23 19:31, Henrik Grimler wrote: >>> Hi Jaehoon, >>> >>> On Fri, Feb 10, 2023 at 09:00:33AM +0900, Jaehoon Chung wrote: >>>> Hi, >>>> >>>>> -----Original Message----- >>>>> From: U-Boot <u-boot-boun...@lists.denx.de> On Behalf Of Henrik >>>>> Grimler >>>>> Sent: Thursday, February 9, 2023 4:04 AM >>>>> To: jo...@diskos.nl; jh80.ch...@gmail.com; andy...@sony.com; >>>>> s...@chromium.org; m.szyprow...@samsung.com; u-boot@lists.denx.de; >>>>> ~postmarketos/upstream...@lists.sr.ht >>>>> Cc: Henrik Grimler <hen...@grimler.se> >>>>> Subject: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the >> SDHCI_QUIRK_BROKEN_R1B" >>>>> >>>>> This reverts commit a034ec06ff1d558bbe11d5ee05edbb4de3ee2215. >>>>> >>>>> Commit 4a3ea75de4c5 ("Revert "mmc: sdhci: set to INT_DATA_END when >>>>> there are data"") reverted the alternative fix that was added for >>>>> Exynos 4 devices, causing an error when trying to boot from an sdcard: >>>>> >>>>> <...> >>>>> Loading Environment from MMC... sdhci_send_command: Timeout >> for status update! >>>>> mmc fail to send stop cmd >>>>> <...> >>>> >>>> Thanks for sharing issue. >>>> >>>> I will check this on Exynos Board. Frankly, I hope not to re-add QUIRK. >>>> Because it was verified that it was working fine without >> SDHCI_QUIKR_BROKEN_RIB. >>> >>> Just wondering if you have had an opportunity to test this on any of >>> your devices? You can find v2 here, though this patch had no changes: >>> INVALID URI REMOVED >>> >> 3-February/508928.html__;!!JmoZiZGBv3RvKRSx!5wpP-x5Y69S7MynP1sOmQI >> HaVG >>> N9_ZLl5dxDDenNWPHdwFnNPdAEvBrUt69tSpQ9o0Nv-LQ9Gie_aGgP$ >> >> In my opinion, >> >> commit 4a3ea75de4c5b3053eac326bf1c753ed65df8cb9 >> Author: yuezhang...@sony.com <yuezhang...@sony.com> >> Date: Wed Mar 17 06:44:37 2021 +0000 >> >> Revert "mmc: sdhci: set to INT_DATA_END when there are data" >> >> This reverts commit 17ea3c862865c0d704646f67dbf8412f9ff54f59. >> >> Revert the above commit. >> >> To Andy, >> >> Was there any problem without above commit? >> >> >> Best Regards, >> Jaehoon Chung >> >> >>> >>>> Best Regards, >>>> Jaehoon Chung >>> >>> Best regards, >>> Henrik Grimler >>> >>>>> >>>>> Re-add the quirk to allow booting from sdcards again. >>>>> >>>>> Signed-off-by: Henrik Grimler <hen...@grimler.se> >>>>> --- >>>>> drivers/mmc/s5p_sdhci.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index >>>>> dee84263c3fd..3b74feae68c7 100644 >>>>> --- a/drivers/mmc/s5p_sdhci.c >>>>> +++ b/drivers/mmc/s5p_sdhci.c >>>>> @@ -90,7 +90,7 @@ static int s5p_sdhci_core_init(struct sdhci_host >> *host) >>>>> host->name = S5P_NAME; >>>>> >>>>> host->quirks = SDHCI_QUIRK_NO_HISPD_BIT | >> SDHCI_QUIRK_BROKEN_VOLTAGE | >>>>> - SDHCI_QUIRK_32BIT_DMA_ADDR | >>>>> + SDHCI_QUIRK_BROKEN_R1B | SDHCI_QUIRK_32BIT_DMA_ADDR >> | >>>>> SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_USE_WIDE8; >>>>> host->max_clk = 52000000; >>>>> host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | >> MMC_VDD_165_195; >>>>> -- >>>>> 2.30.2 >>>> >>>>