On 28.03.23 11:30, Sebastian Andrzej Siewior wrote: > On 2023-03-28 09:53:28 [+0200], Frieder Schrempf wrote: >> On 28.03.23 09:47, Sebastian Andrzej Siewior wrote: >>> The board is similar to "Kontron SL i.MX8M Mini" SoM. There are two >>> variants. >>> Snowflake_v2 has an external SDCard Interface. LEIG is the same, but without >>> display and without external SDCard Interface. Both variants support >>> only 1GiB of main memory. >>> >>> Signed-off-by: Manuel Traut <manuel.tr...@mt.com> >>> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> >>> --- >>> v1…v2: >>> - Clarify details about the board and whether or not there is an >>> external SD-card interface. >> >> What about my other review comments to v1? > > I update the Name to "Kontron SL i.MX8M Mini" SoM in the description but > forgot to add it to the changelog. Was there something else missed?
You can easily answer that yourself, by looking at the comments I made in [1]. There are comments for the DT compatible, the PMIC node, the I2C1 pinctrl node and the DDR init code you haven't responded to. [1] https://patchwork.ozlabs.org/project/uboot/patch/20230310135021.krabf...@linutronix.de/#3078257