On 3/27/23 23:14, jassisinghb...@gmail.com wrote:
From: Jassi Brar <jaswinder.si...@linaro.org>

Introduce support for mtd backed storage for FWU feature and enable it on
Synquacer platform based DeveloperBox.

This revision is rebased onto patchset that trims the FWU api
  
https://lore.kernel.org/u-boot/20230306231747.1888513-1-jassisinghb...@gmail.com/

When I build it on the top of this series for our SOC I am getting

   aarch64:  +   xilinx_zynqmp_virt
+lib/fwu_updates/fwu.o: In function `fwu_boottime_checks':
+build/../lib/fwu_updates/fwu.c:633: undefined reference to 
`fwu_plat_get_bootidx'
+lib/fwu_updates/fwu.o: In function `fwu_get_image_index':
+build/../lib/fwu_updates/fwu.c:381: undefined reference to 
`fwu_plat_get_alt_num'
+make[1]: *** [Makefile:1754: u-boot] Error 139
+make[1]: *** Deleting file 'u-boot'
+make: *** [Makefile:177: sub-make] Error 2

That means that I can select these options and I will get compilation error.
I understand the error but if anybody can select it you should use weak functions or so to be able to get it at least build.

The series doesn't look bad but still the biggest issue remains which is that DT binding is not approved by DT guys which pretty much means that any platform which starts to use this code can't pass DT yaml checking enforced by SR 2.0.

Thanks,
Michal

Reply via email to