Hi Heinrich, On Fri, 31 Mar 2023 at 11:48, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > > > Am 30. März 2023 23:32:21 MESZ schrieb Simon Glass <s...@chromium.org>: > >To save a few bytes, replace Error with ** and try to use the same string > >for multiple messages where possible. > > > >Signed-off-by: Simon Glass <s...@chromium.org> > >--- > > > > fs/fat/fat.c | 12 ++++++------ > > fs/fat/fat_write.c | 14 ++++---------- > > 2 files changed, 10 insertions(+), 16 deletions(-) > > > >diff --git a/fs/fat/fat.c b/fs/fat/fat.c > >index 2da93dae3cf3..f0df7988e172 100644 > >--- a/fs/fat/fat.c > >+++ b/fs/fat/fat.c > >@@ -97,8 +97,8 @@ int fat_register_device(struct blk_desc *dev_desc, int > >part_no) > > /* Read the partition table, if present */ > > if (part_get_info(dev_desc, part_no, &info)) { > > if (part_no != 0) { > >- printf("** Partition %d not valid on device %d **\n", > >- part_no, dev_desc->devnum); > >+ printf("** Partition %d invalid on device %d **\n", > >+ part_no, dev_desc->devnum); > > return -1; > > } > > > >@@ -168,7 +168,7 @@ static __u32 get_fatent(fsdata *mydata, __u32 entry) > > __u32 ret = 0x00; > > > > if (CHECK_CLUST(entry, mydata->fatsize)) { > >- printf("Error: Invalid FAT entry: 0x%08x\n", entry); > >+ printf("** Invalid FAT entry: %#08x\n", entry); > > The ** is superfluous. The text makes it clear that an error occured
So should I drop the other ** strings in these files too? Please take a look and see what you think. [..] Regards, Simon