Hi.
Le samedi 1 avril 2023, 07:32:14 WEST Simon Glass a écrit : > Hi Francis, > > On Fri, 31 Mar 2023 at 08:49, Francis Laniel > > <francis.lan...@amarulasolutions.com> wrote: > > This command can be used to print the current parser with 'parser print'. > > It can also be used to set the current parser with 'parser set'. > > For the moment, only one value is valid for set: old. > > > > Signed-off-by: Francis Laniel <francis.lan...@amarulasolutions.com> > > --- > > > > cmd/Makefile | 2 + > > cmd/parser.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > common/cli.c | 3 +- > > 3 files changed, 124 insertions(+), 1 deletion(-) > > create mode 100644 cmd/parser.c > > Reviewed-by: Simon Glass <s...@chromium.org> Thank you for the reviews! > > But I wonder whether 'cli' might be a better name for this command? We > use cli everywhere else. "Naming thing is hard" [1]. Thank you for the suggestion! I changed it to cli which I think is a better name as it is less abstract than parser. > Also can you add doc/usage for this? Done! I was not aware of doc/usage/cmd before. > Regards, > Simon By the way, I also addressed your other comments on patches 4 and 9. Best regards. --- [1] https://www.karlton.org/2017/12/naming-things-hard/
