On Thu, 6 Apr 2023 at 19:28, Tom Rini <tr...@konsulko.com> wrote: > > When building with clang, we see: > board/emulation/common/qemu_dfu.c:51:24: warning: 'memset' call operates on > objects of type 'char' while the size is based on a different type 'char *' > [-Wsizeof-pointer-memaccess] > > As we're calling memset with the length set to the size of the pointer > and not the size of the buffer. Correct this with a call of the size of > the buffer itself. > > Signed-off-by: Tom Rini <tr...@konsulko.com> > ---
Acked-by: Sughosh Ganu <sughosh.g...@linaro.org> -sughosh > Cc: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi> > Cc: Sughosh Ganu <sughosh.g...@linaro.org> > Cc: Simon Glass <s...@chromium.org> > --- > board/emulation/common/qemu_dfu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/emulation/common/qemu_dfu.c > b/board/emulation/common/qemu_dfu.c > index 332d659c1f7c..7e7d84f6c00f 100644 > --- a/board/emulation/common/qemu_dfu.c > +++ b/board/emulation/common/qemu_dfu.c > @@ -48,7 +48,7 @@ void set_dfu_alt_info(char *interface, char *devstr) > env_get("dfu_alt_info")) > return; > > - memset(buf, 0, sizeof(buf)); > + memset(buf, 0, DFU_ALT_BUF_LEN); > > /* > * Currently dfu_alt_info is needed on Qemu ARM64 for > -- > 2.34.1 >