On 4/14/23 06:24, Nishanth Menon wrote:
Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes
with Linux") reordered the enum definitions. This exposed a problem in
range checking functions to identify the interface type. Though this
specific api was'nt impacted (all the RGMII definitions remained within

Nit: "wasn't" , apostrophe in the wrong place .

range), this experience should be used to never to have to face this
kind of challenge again.

While it is possible for the phy drivers to practically use the enum's
directly, drivers such as dp83867, dp83869, marvell, micrel_ksz90x1 etc
use the same.

Reported-by: Tom Rini <tr...@konsulko.com>
Signed-off-by: Nishanth Menon <n...@ti.com>

Reviewed-by: Marek Vasut <marek.vasut+rene...@mailbox.org>

Reply via email to