On Fri, Apr 14, 2023 at 8:53 AM Michal Simek <michal.si...@amd.com> wrote: > > > > On 4/10/23 06:05, Jassi Brar wrote: > > On Wed, 29 Mar 2023 at 07:29, Michal Simek <michal.si...@amd.com> wrote: > >> On 3/27/23 23:16, jassisinghb...@gmail.com wrote: > > > >>> diff --git a/tools/mkfwumdata.c b/tools/mkfwumdata.c > >>> new file mode 100644 > >>> index 0000000000..43dabf3b72 > >>> --- /dev/null > >>> +++ b/tools/mkfwumdata.c > >>> @@ -0,0 +1,334 @@ > >>> +// SPDX-License-Identifier: GPL-2.0+ > >>> +/* > >>> + * Copyright (c) 2023, Linaro Limited > >>> + */ > >>> + > >>> +#include <errno.h> > >>> +#include <getopt.h> > >>> +#include <limits.h> > >>> +#include <stdio.h> > >>> +#include <stdint.h> > >>> +#include <stdlib.h> > >>> +#include <string.h> > >>> +#include <u-boot/crc.h> > >>> +#include <unistd.h> > >>> +#include <uuid/uuid.h> > >>> + > >>> +/* This will dynamically allocate the fwu_mdata */ > >>> +#define CONFIG_FWU_NUM_BANKS 0 > >>> +#define CONFIG_FWU_NUM_IMAGES_PER_BANK 0 > >> > >> These two are completely unused. > >> > > these are necessary for include/fwu_mdata.h that comes later. > > If that's come later, add it later. > Can you please actually look at the code to see the underlying constraint?
-j