On Tue, Apr 25, 2023 at 10:02:01PM +0200, Rasmus Villemoes wrote: > On 25/04/2023 21.31, Tom Rini wrote: > > On Fri, Mar 17, 2023 at 11:26:39AM +0100, Rasmus Villemoes wrote: > > > > >> Now, the only way to be really sure is to build the world > >> with/without this patch and check if any .dtb file changes, but I > >> don't have the means to do that. > > > > So, yes, this causes a bunch of fail to builds, as you noted above. The > > easiest way I think to confirm things before / after would be to make a > > quick change to tools/buildman/builderthread.py and self.CopyFiles line > > for keep_outputs to also keep the dtb or some dts files so you can diff > > before / after to make sure the end result is the same. > > Do the builds outright fail, or do they fail in the sense that some > machinery detects a change in the binary artifacts? Can you point me at > one or two CI builds that show this?
They outright fail to build, mt8516_pumpkin is the one I was testing with. CI didn't get to the point of failing on that particular problem (as it's in the last stage and qemu randomly failed as it does earlier). -- Tom
signature.asc
Description: PGP signature
