On Sat, Apr 15, 2023 at 1:06 AM Nishanth Menon <[email protected]> wrote:
>
> dp83867 driver only supports sgmii and not all the newer protocols.
> Drop the usage of the generic phy_interface_is_sgmii function and just
> matchup to the specific mode supported.
>
> Reported-by: Tom Rini <[email protected]>
> Suggested-by: Marek Vasut <[email protected]>
> Suggested-by: Marek Behún <[email protected]>
> Link:
> https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Nishanth Menon <[email protected]>
> ---
> Changes since v2:
> * New patch.
>
> drivers/net/phy/dp83867.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index b861bf7cef36..7111e36aa0d0 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -330,7 +330,7 @@ static int dp83867_config(struct phy_device *phydev)
> DP83867_RGMIIDCTL, delay);
> }
>
> - if (phy_interface_is_sgmii(phydev)) {
> + if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {
> if (dp83867->sgmii_ref_clk_en)
> phy_write_mmd(phydev, DP83867_DEVADDR,
> DP83867_SGMIICTL,
> DP83867_SGMII_TYPE);
> --
> 2.40.0
>
Reviewed-by: Ramon Fried <[email protected]>
