On Thu, 1 Jun 2023 at 12:28, Simon Glass <s...@chromium.org> wrote: > > On Tue, 30 May 2023 at 21:36, Masahisa Kojima > <masahisa.koj...@linaro.org> wrote: > > > > Current efi capsule python tests have much code duplication. > > This commit creates the common function > > in test/py/tests/test_efi_capsule/capsule_common.py, > > aim to reduce the code size and improve maintainability. > > > > Signed-off-by: Masahisa Kojima <masahisa.koj...@linaro.org> > > --- > > Newly created in v7 > > > > .../tests/test_efi_capsule/capsule_common.py | 86 +++++++ > > .../test_capsule_firmware_fit.py | 151 +++--------- > > .../test_capsule_firmware_raw.py | 224 +++--------------- > > .../test_capsule_firmware_signed_fit.py | 198 +++------------- > > .../test_capsule_firmware_signed_raw.py | 210 +++------------- > > 5 files changed, 231 insertions(+), 638 deletions(-) > > create mode 100644 test/py/tests/test_efi_capsule/capsule_common.py > > Reviewed-by: Simon Glass <s...@chromium.org> > > Thank you. > > Please do comment your function arguments.
OK, I will add comments on function arguments. Thanks, Masahisa Kojima