Dne petek, 09. junij 2023 ob 12:56:19 CEST je Andre Przywara napisal(a): > In its of_xlate() function, the Allwinner USB PHY driver compares the > args_count variable against the number of implemented USB PHYs, although > this is the *number of arguments* to the DT phandle property. Per the DT > binding for this PHY device, this number is always one, so this check > will always fail if the particular SoC implements exactly one USB PHY. > So far this affected only the V3s (which has USB support disabled), but > the F1C100s also sports one PHY only. > > Fix that check to compare args_count against exactly 1, and the args[0] > content (requested PHY number) against the number of implemented PHYs. > > This fixes USB operation on the Allwinner V3s and allows to enable USB > on the Allwinner F1C100s SoC. > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
Nice catch! Reviewed-by: Jernej Skrabec <jernej.skra...@gmail.com> Best regards, Jernej