Hi Nikhil,
On 14/06/23 15:04, Nikhil M Jain wrote:
> Use spl_dcache_enable, in place of setup_dram, arch_reserve_mmu to set
> up pagetable, initialise DRAM and enable Dcache.
>
I think the patch does more than just above, please mention about those
changes too in commit message for future reference.
> Signed-off-by: Nikhil M Jain <n-ja...@ti.com>
> ---
> V3:
> - No change.
>
> V2:
> - Use CONFIG_SPL_VIDEO in place of CONFIG_SPL_VIDEO_TIDSS to reserve
> video and call splash at SPL.
> - Check SPL_SPLASH_SCREEN and SPL_BMP before calling splash display.
Above should also go to commit message with reasoning along with other changes
done in the patch.
Regards
Devarsh
>
> arch/arm/mach-k3/am625_init.c | 1 +
> board/ti/am62x/evm.c | 41 +++++++++++++----------------------
> 2 files changed, 16 insertions(+), 26 deletions(-)
>
> diff --git a/arch/arm/mach-k3/am625_init.c b/arch/arm/mach-k3/am625_init.c
> index 787fe92295..0e5d44269e 100644
> --- a/arch/arm/mach-k3/am625_init.c
> +++ b/arch/arm/mach-k3/am625_init.c
> @@ -214,6 +214,7 @@ void board_init_f(ulong dummy)
> if (ret)
> panic("DRAM init failed: %d\n", ret);
> #endif
> + spl_enable_dcache();
> }
>
> u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
> diff --git a/board/ti/am62x/evm.c b/board/ti/am62x/evm.c
> index 34830f445f..d3c1786cd9 100644
> --- a/board/ti/am62x/evm.c
> +++ b/board/ti/am62x/evm.c
> @@ -59,42 +59,31 @@ int dram_init_banksize(void)
> }
>
> #if defined(CONFIG_SPL_BUILD)
> -#ifdef CONFIG_SPL_VIDEO_TIDSS
> -static int setup_dram(void)
> -{
> - dram_init();
> - dram_init_banksize();
> - gd->ram_base = CFG_SYS_SDRAM_BASE;
> - gd->ram_top = gd->ram_base + gd->ram_size;
> - gd->relocaddr = gd->ram_top;
> - return 0;
> -}
> -
> static int video_setup(void)
> {
> - ulong addr;
> - int ret;
> - addr = gd->relocaddr;
> + if (CONFIG_IS_ENABLED(VIDEO)) {
> + ulong addr;
> + int ret;
> +
> + addr = gd->relocaddr;
> + ret = video_reserve(&addr);
> + if (ret)
> + return ret;
> + debug("Reserving %luk for video at: %08lx\n",
> + ((unsigned long)gd->relocaddr - addr) >> 10, addr);
> + gd->relocaddr = addr;
> + }
>
> - ret = video_reserve(&addr);
> - if (ret)
> - return ret;
> - debug("Reserving %luk for video at: %08lx\n",
> - ((unsigned long)gd->relocaddr - addr) >> 10, addr);
> - gd->relocaddr = addr;
> return 0;
> }
>
> -#endif
> void spl_board_init(void)
> {
> -#if defined(CONFIG_SPL_VIDEO_TIDSS)
> - setup_dram();
> - arch_reserve_mmu();
> video_setup();
> enable_caches();
> - splash_display();
> -#endif
> + if (IS_ENABLED(CONFIG_SPL_SPLASH_SCREEN) && IS_ENABLED(CONFIG_SPL_BMP))
> + splash_display();
> +
> }
>
> #if defined(CONFIG_K3_AM64_DDRSS)
