Hi Frank,
On Mon, 26 Jun 2023 at 11:44, Frank Wunderlich <fran...@public-files.de> wrote:
>
> Hi,
>
> what exact bug does the Patch fix? as i'm listed in reported-By...i remember
> only the problem with missing line-breaks after "normal" menuitems and the
> "u-boot-console" i reported in ML. But i don't think this is related to ANSI
> processing.
It fixes placement of the prompt to select an option. You can ignore
this patch if it isn't related to your report.
Regards,
Simon
>
> regards Frank
>
>
> > Gesendet: Montag, 12. Juni 2023 um 22:14 Uhr
> > Von: "Simon Glass" <s...@chromium.org>
> > An: "U-Boot Mailing List" <u-boot@lists.denx.de>
> > Cc: "Simon Glass" <s...@chromium.org>, "Pali Rohár" <p...@kernel.org>,
> > "Mark Kettenis" <mark.kette...@xs4all.nl>, "Frank Wunderlich"
> > <fran...@public-files.de>, "Heinrich Schuchardt" <xypron.g...@gmx.de>,
> > "Ilias Apalodimas" <ilias.apalodi...@linaro.org>, "Masahisa Kojima"
> > <masahisa.koj...@linaro.org>, "Stefan Roese" <s...@denx.de>
> > Betreff: [PATCH] menu: Re-enable the ANSI codes
> >
> > The intent here was to allow ANSI codes to be disabled, since it was
> > proving impoosible to test operation of the menu code when it kept moving
> > the cursor. Unfortunately this ended up in the patch.
> >
> > Correct this by enabling ANSI again.
> >
> > Signed-off-by: Simon Glass <s...@chromium.org>
> > Reported-by: Pali Rohár <p...@kernel.org>
> > Reported-by: Mark Kettenis <mark.kette...@xs4all.nl>
> > Reported-by: Frank Wunderlich <fran...@public-files.de>
> > Fixes: 32bab0eae51b ("menu: Make use of CLI character processing")
> > ---
> >
> > common/menu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/menu.c b/common/menu.c
> > index 94514177e4e9..b55cf7b99967 100644
> > --- a/common/menu.c
> > +++ b/common/menu.c
> > @@ -15,7 +15,7 @@
> >
> > #include "menu.h"
> >
> > -#define ansi 0
> > +#define ansi 1
> >
> > /*
> > * Internally, each item in a menu is represented by a struct menu_item.
> > --
> > 2.41.0.162.gfafddb0af9-goog
> >
> >
