> > While you are here, or in a follow-up patch, can you please add full > comments to net_set_ip_header(), e,g. what is the pkt param exactly? > The whole packet, before any headers?
It's an IP header. Added comment and renamed the argument on this one and net_set_udp_header. On Sun, Jul 23, 2023 at 4:48 AM Simon Glass <s...@chromium.org> wrote: > Hi Dmitrii, > > On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev <dimori...@google.com> > wrote: > > > > Changes: > > 1. Separate reusable part from net_set_tcp_header to > > net_set_tcp_header_common > > 2. Make TCP signatures reusable by receiving particular > > IP agnostic TCP headers > > 3. Extract net_send_ip_packet6 from net_send_udp_packet6 > > to reuse the code > > 4. Expose TCP state machine related functions > > > > This allows us to reuse TCP logic between IP and IP6 stack. > > > > Signed-off-by: Dmitrii Merkurev <dimori...@google.com> > > Cc: Ying-Chun Liu (PaulLiu) <paul....@linaro.org> > > Cc: Simon Glass <s...@chromium.org> > > Сс: Joe Hershberger <joe.hershber...@ni.com> > > Сс: Ramon Fried <rfried....@gmail.com> > > --- > > include/net/tcp.h | 109 +++++++++++++-- > > net/net.c | 18 ++- > > net/net6.c | 78 ++++++++--- > > net/tcp.c | 337 ++++++++++++++++++++++++++++------------------ > > 4 files changed, 372 insertions(+), 170 deletions(-) > > Reviewed-by: Simon Glass <s...@chromium.org> > > While you are here, or in a follow-up patch, can you please add full > comments to net_set_ip_header(), e,g. what is the pkt param exactly? > The whole packet, before any headers? >