Re: [PATCH v2 2/2] rockchip: edgeble-neu6: Append eMMC into spl-boot-order

[Kever Yang]

Hi Jagan,

On 2023/7/19 16:17, Jagan Teki wrote:
Now, edgeble-neu6 NCM IO boards support eMMC and SDMMC.
So, Update the spl-boot-order to include both.

Signed-off-by: Jagan Teki <ja...@edgeble.ai>
---
Changes for v2:
- None

  arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi | 10 ++--------
  arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi | 10 ++--------
  2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi 
b/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
index 373f369c65..7ddfd98770 100644
--- a/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
+++ b/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
@@ -7,16 +7,10 @@
  
  / {
        aliases {
-               mmc0 = &sdmmc;

It would be better to keep "mmc0 = &sdhci " than remove it, otherwise 
you may need to add it back for emmc support in U-Boot proper later.


Thanks,

- Kever


+               mmc1 = &sdmmc;
        };
  
  	chosen {
-               stdout-path = &uart2;
-               u-boot,spl-boot-order = &sdmmc;
+               u-boot,spl-boot-order = "same-as-spl", &sdmmc, &sdhci;
        };
  };
-
-&sdmmc {
-       bus-width = <4>;
-       status = "okay";
-};
diff --git a/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi 
b/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi
index cd7626b24b..2bc1a98ff8 100644
--- a/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi
+++ b/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi
@@ -7,16 +7,10 @@
  
  / {
        aliases {
-               mmc0 = &sdmmc;
+               mmc1 = &sdmmc;
        };
  
  	chosen {
-               stdout-path = &uart2;
-               u-boot,spl-boot-order = &sdmmc;
+               u-boot,spl-boot-order = "same-as-spl", &sdmmc, &sdhci;
        };
  };
-
-&sdmmc {
-       bus-width = <4>;
-       status = "okay";
-};